Use d3-dsv package for parsing tsv/csv files. #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction which converts values from tsv/csv file to javascript types.
mkuthan
approved these changes
Apr 29, 2021
| @@ -197,6 +197,39 @@ dataCubes: | |||
| title: Records count | |||
| formula: $main.count() | |||
|
|
|||
| - name: unemployment | |||
Could you compare the size of the final bundle, please? |
No difference at all. 5940532 vs 5940532 |
|
@geohci did you have a chance to test it on your end? |
|
Thanks for the ping @adrianmroz-allegro -- pulled in the branch and worked perfectly for me (both TSV and CSV). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #738
Around version 4, d3 changed it distribution model. Before it sued one package for all modules, later each module got it own package. We can't easily update d3 to version 4 (or later).
I added d3-dsv package. In theory I added package that duplicates functionality of d3 package. But webpack should not include d3 functions for handling csv/tsv to client code (due to tree shaking) and d3-dsv is only used on server (I even moved parser util from common to server).